Repository navigation
chore(utxo-lib): bump bip174 to 3.1.0-master.5 - #10183
Merged
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Contributor
|
|
Update @bitgo-forks/bip174 from 3.1.0-master.4 to 3.1.0-master.5 in utxo-lib, utxo-core, utxo-staking and abstract-lightning. master.5 rejects non-canonical CompactSize varint encodings when parsing a PSBT, matching Bitcoin Core. Ticket: CSHLD-2225
prikshitchawla300
force-pushed
the
prikshitchawla/cshld-2225-bump-bip174
branch
from
November 16, 2026 09:10
a3b9755 to
18b6c14
Compare
sijuu
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
@bitgo-forks/bip174from3.1.0-master.4to3.1.0-master.5inutxo-lib,utxo-core,utxo-stakingandabstract-lightning.master.5(BitGo/bip174#25) rejects non-canonical CompactSize varint encodings when parsing a PSBT, matching Bitcoin Core.Notes
@bitgo-forks/bitcoinjs-lib@7.1.0-master.11still pinsbip174@3.1.0-master.4, so code that parses through the bitcoinjs-libPsbtclass keeps the old version until that fork is bumped.UtxoPsbt.fromBufferimportsbip174directly and resolves tomaster.5.babylonlabs-io-btc-staking-tsuses upstreambip174@2.1.1and is unchanged.Testing
utxo-lib:tsc --noEmitclean,mocha --recursive test4254 passing.